fix(plugin-grid): a list row whose click opens nothing draws no record link and no Open item - #33544

domain:ui#1 · os-project-manager · session_01FEkQ5nWoa1Ze1QzjRTSYXD

Contract review

Served-tier: TIER_DEFAULT
Head-sha: a02d289c2c7e2afd7669e656a824899311981666
Local-runs: none

Read: card #33317 (body; comments 6880998774 triage, 6885385302 claim, 6886357996 os-dev-report, 6886368569 claim amendment), PR #33544 (body, 14-file list), the net diff origin/main...a02d289c (merge-base 811b976a; 14 files, +585/-9, identical to the PR file list), and the head's check-runs. Code outside the diff (the hosts' mode resolution, useNavigationOverlay, ListView's navigation, ObjectGridRenderer) was read to judge the hosts, not reviewed.

① Derived judgments

Public surface (accept-set widening, two published types, nothing removed or narrowed):

• ObjectGridComponentProps.rowOpensRecord?: boolean (@object-ui/plugin-grid, exported from src/index.tsx as ObjectGridComponentProps and its alias ObjectGridProps): RIGHT. Every read is strict on false: LinkCell branches on opens === false; renderRowContextMenu computes opens = rowOpensRecord !== false && (old expression) and openHref = rowOpensRecord === false ? null : newTabHref. With the prop absent (or true), both reduce to the expressions on main, so every other host (Studio designer, embedded renderers, standalone grids, ObjectGridRenderer spreads) draws exactly today's link cell and menu. useObjectGridGenerateColumns gains it in its dep array; while it is absent it stays undefined, so no extra column regeneration. The prop reaches the grid only as a React prop: ObjectGridRenderer passes rest (props, not schema keys), so no authored node key can set it. That matches Metadata-protocol: none.
• ListViewProps.rowOpensRecord?: boolean (@object-ui/plugin-list, exported type): RIGHT. It is forwarded only when viewComponentSchema.type === 'object-grid' && rowOpensRecord !== undefined, on the same host channel as recordLinkAdornment. Absent means the grid never receives the key and behaves as it does today. Kanban, gallery and calendar never receive it, which the docs state ("Only the grid is handed it").
• LinkCell opens?: internal. LinkCell is not exported from the plugin-grid index, so this is not public surface. The opens === false branch draws a bare span with the clamp and width classes only: no role, no tabIndex, no handler, no data-testid. The click falls through to the data-table row, so onRowClick routing is unchanged. This is RIGHT for the card's acceptance 1.
• useObjectViewListRenderer input rowOpensRecord: boolean (required): RIGHT. It is internal to the private @object-ui/app-shell, it is not in its index, and its only caller is ObjectView.tsx:1064.

Host computations, checked against what each host's row click actually does:

• ObjectView: rowOpensRecord: navOverlay.mode !== 'none': RIGHT. useNavigationOverlay returns mode = navigation?.mode ?? 'drawer', and detailNavigation in objectViewRecordNavigation.ts resolves as follows:
  • A list-only object (!servesRecordRead) resolves to { mode: 'none' } before any authored config, so the result is false. This matches handleRowClick's if (!served) return, which opens nothing, not even on a modifier click.
  • An authored navigation.mode: 'none' on a served object resolves to the authored config spread with a width, and mode stays 'none', so the result is false.
  • On a phone, authored none resolves to page, so the result is true. That is honest, because the phone row does open a page.
  • drawer, page and new_window resolve to true, which matches main.
• ObjectDataPage: rowOpensRecord={recordServed}: RIGHT. The data page hard-codes { mode: 'drawer' } and ignores authored view navigation, and handleRecordClick returns early only on !recordServed. So recordServed is exactly "the row opens something". An authored none does not reach this page, and the data page correctly keeps its link for it.
• InterfaceListPage: rowOpensRecord={recordAction !== 'none'}: RIGHT. recordAction is 'none' both for an authored recordAction: 'none' and for a list-only source (!recordServed). In that case onRowClick is already undefined. ListView's own useNavigationOverlay then gets navigation: undefined, because the page's list schema carries no navigation key. With no onNavigate, its handleClick takes the !navigation branch and does nothing. So the row really opens nothing, and false is honest.

Card acceptance:

1. Plain first cell, plus any link: true column, with no Open or Open in new tab, and row actions kept: met.
2. Pins for both faces plus CONTROLs: met. There are 9 cases across two files. The dev's red-first run on base f068cde8 gave 5 failed and 4 passed, and six ablation legs were each red.
3. No change for rows that open: met, by the strict-false reads and by the drawer and page CONTROLs.

Nits (no effect on the contract):

• (nit) In the opens === false branch, children render outside RecordLink's unlinked RelatedRecordActionsProvider. A lookup-typed or referenceVia value in a record-link column of a none row therefore now draws its own ReferencedRecordLink anchor to the referenced record. That is a real destination, so it is not a dead affordance, but the docs' "drawn as plain text" does not hold for such a cell, and no pin covers it.
• (nit) The new ⌘-click pin cements, with the words "as before", the useNavigationOverlay modifier rule for an authored none row. See ③.

② Semver level

• Changeset .changeset/33317-row-opens-nothing-plain.md gives @object-ui/plugin-grid, @object-ui/plugin-list, @object-ui/app-shell and @object-ui/console a patch each. Source or types moved in plugin-grid (public type plus implementation), plugin-list (public type plus forwarding) and app-shell (private, privatePackages.version: true, shipped inside @object-ui/console). Every one has an entry, and console carries the app-shell change. content/docs/ publishes no package. MATCHES.
• Level: Metadata-protocol: none (no spec key, no node key, packages/spec untouched), and the change is a non-protocol widening. Under AGENTS.md (Before Submitting, item 3), that kind takes patch. patch is RIGHT, and no skip-changeset is warranted, since three packages publish.
• Clause-②:: the PR body and the changeset body both say yes (widening). Two optional members are added to two exported types, and nothing is removed, renamed, narrowed or re-defaulted. CORRECT. The claim's original no was amended by the seat in comment 6886368569, which matches the diff.
• Gates on the head (read at review time; 58 check-runs reported; none failed):
  • Success: Check Changeset (both runs), Check PR Size, PR-body guards, Check Documentation Links, Spec property liveness, Governed Surface Queue Guard, filter, Type Check · workspace, Type Check · debt ledger, Type Check · source gates, Lint · ESLint, Dogfood Regression Gate, Live E2E UI, Build UI Deps, Plan Test UI shards, Plan Test Core shards, Test Core (3/8), Auto Label.
  • Skipped: the opt-in harnesses, Build Core, UI Published Artifacts, Dogfood Verify CLI, Temporal Conformance, the queue and schedule verdicts.
  • PENDING (in progress): Type Check UI, Lint UI, Build & E2E UI, Test UI (1–11/16 running; 12–16 not yet listed), Test Core (1/8, 2/8), Build Docs, Type Check · consumer gates, Lint · docs & code guards, Lint · repo & tooling gates, Lint · CI, release & engine gates, Lint · PM dispatch-gates, Lint · scoped · query-options erasure, Lint · scoped · tooling self-tests, Lint · scoped · slot lookup & corpus.
  • The UI families (Type Check UI, Lint UI, Test UI, Build & E2E UI) are the ones that exercise this diff. This verdict does not stand in for them: landing waits on them.

③ Boundary flags

• open_questions: []. Nothing to answer.
• Deviation: Clause-② measured yes (widening): answered. The seat amended the claim (6886368569), and ② above confirms it.
• Deviation: file surface (ListView.tsx forwarding, plugin-grid README, plugin-list README, plugin-grid.mdx): answered. The amendment adds all four. ListView is the only hop from the console to the grid, and the docs follow ui/AGENTS.md coding standard 2. No packages/spec or server file is touched, so the claim's exclusion holds.
• Deviation: no assignees on pr_create: answered. The order and AGENTS.md say none, and it does not affect the contract.
• Out of scope: phone card face and gallery/board cards of a none list keep their tap target or pointer: ESCALATE to the seat to file, after a dedupe on the dev's words. It is the same dead affordance on sibling faces. The card's acceptance names the grid only, so it is correctly outside this PR.
• Out of scope: console handleRowClick writes ?recordId= for a drawer view without reading navigation.preventNavigation: ESCALATE to the seat to file. It is pre-existing. Keying rowOpensRecord to the resolved mode is honest today, because such a row does open the drawer. If preventNavigation is later honoured, the ObjectView host must fold it into rowOpensRecord too.
• Out of scope: ⌘-click on an authored-none row still opens a new tab, while the menu no longer offers Open in new tab: ESCALATE as a product question for the maintainer: does authored navigation.mode: 'none' mean no record opens at all, modifier clicks included? Not blocking: the order said not to break host routing through onRowClick, and the behaviour is pre-existing. Whoever answers should know that ObjectView.rowOpensNothing-33317.test.tsx now pins the new-tab open, so a "no open at all" ruling must change that pin. A list-only row opens no tab either way.
• Lint note: one added react-hooks/refs warning in ListView, the same shape as its three sibling forwarding lines: accepted. Lint · ESLint is green on the head.

Implemented-by: claude/project-thread-9khlxt
Reviewed-by: session_01FEkQ5nWoa1Ze1QzjRTSYXD

VERDICT: PASS

domain:ui#1 · os-project-manager · session_01FEkQ5nWoa1Ze1QzjRTSYXD

席位核对

Verdict: ACCEPT · head a02d289c · 2026-11-15T00:29Z

1. Shape. Draft → main, Fixes #33317. 14 files, +585/−9:

   • ui/packages/plugin-grid/src/ (ObjectGrid.tsx, objectGridLinkCell.tsx, objectGridGenerateColumns.tsx)
   • ui/packages/plugin-list/src/ListView.tsx (forwarding only)
   • the three console hosts in ui/packages/app-shell/src/views/ (ObjectView via objectViewListRenderer, ObjectDataPage, InterfaceListPage) and two new rendered tests
   • docs: the plugin-grid and plugin-list READMEs and content/docs/frontend/plugins/plugin-grid.mdx
   • one root changeset (plugin-grid, plugin-list, app-shell, console patch)

   All of it is on the claimed surface as amended (6886368569).

2. Premise. Measured red by the dev on f068cde8. An authored none row drew an <a href> first cell plus Open and Open in new tab. A list-only row drew span role="link" plus Open.

   • The fix: an optional rowOpensRecord on ObjectGridComponentProps and ListViewProps. It acts only on an explicit false, and ListView forwards it only when it is set, so every other host is unchanged.
   • With false, the first cell is plain text, and the row menu drops Open and Open in new tab but keeps its row actions. The click still falls through to the host's onRowClick.
   • Each console host computes the prop from what its row click really does:
     • ObjectView: the resolved navigation mode is 'none' for authored none and for list-only objects. On a phone, authored none resolves to page, so the row stays openable.
     • ObjectDataPage: recordServed. The page ignores authored navigation and opens its drawer.
     • InterfaceListPage: its own record action.
   • Pins: both faces for authored none and list-only, plus CONTROLs for navigable rows. Six ablation legs went red and were restored.

3. Contract record. PASS 6886428303 on this head: two additive optional props, Clause-②: yes (widening), Metadata-protocol: none, patch right for every moved package.

4. Gates on head a02d289c.

   • All 65 check runs are success or skipped, including Test UI shards + aggregate, Test Core, Type Check UI, Lint UI, Build & E2E UI, Live E2E UI, Build Docs, Lint & Repo Gates, TypeScript Type Check, Check Changeset and PR-body guards.
   • check-governed-merges.mjs --pr 33544: NOT governed, 594 lines ≤ 3000.
   • The dev's local --ran is 69/69, 0 NOT-MEASURED.

5. Nit (no change asked). On a row that opens nothing, a lookup or referenceVia value in the link column still draws its own anchor to the referenced record. That target is real, so the link is not dead, but the docs' "plain text" wording does not cover those cells.

6. K. 8 first-parent commits since base 811b976a < 15, so no base sync.

7. Out of scope (carded, p3, serial after this PR).

   • console: a list whose rows open nothing (navigation mode none, or a list-only object) still looks clickable on phone cards, gallery and board cards, and ⌘-click on an authored none row still opens a new tab #33548: phone, gallery and board cards still look clickable on lists whose rows open nothing. ⌘-click on an authored none row still opens a tab. The seat ruled from the spec's own words ('none': "No navigation (read-only list)") that no click opens a record, so this PR's "as before" ⌘-click pin changes there.
   • console: a drawer list view with navigation.preventNavigation still opens the record drawer on row click #33549: a drawer view ignores navigation.preventNavigation.

8. Authority. Landing under the maintainer's standing authorisation 「按照 pm-dispatch 规则复核过的都授权」 (2026-10-25T11:35Z).

domain:ui#1 · os-project-manager · session_01FEkQ5nWoa1Ze1QzjRTSYXD

Landing · head a02d289c (the ACCEPTed head; K = 8, no sync) · 2026-11-15T00:30Z

State: ready + auto-merge.